typings: fix `ImportModuleDynamicallyCallback` return type · nodejs/node@1521125 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1521125

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

marco-ippolito

committed

typings: fix ImportModuleDynamicallyCallback return type

PR-URL: #57160 Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent f57765b commit 1521125
Copy full SHA for 1521125

2 files changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/esm
  • loader.js
  • utils.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/esm/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -280,7 +280,7 @@ class ModuleLoader {
280	280	* @param {string} source Source code. TODO(joyeecheung): pass the raw buffer.
281	281	* @param {string} isMain Whether this module is a main module.
282	282	* @param {CJSModule|undefined} parent Parent module, if any.
283		- * @returns {{wrap: ModuleWrap, namespace: ModuleNamespaceObject}}
	283	+ * @returns {{wrap: ModuleWrap, namespace: import('internal/modules/esm/utils').ModuleNamespaceObject}}
284	284	*/
285	285	importSyncForRequire(mod, filename, source, isMain, parent) {
286	286	const url = pathToFileURL(filename).href;

Collapse file

‎lib/internal/modules/esm/utils.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/utils.js

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -101,12 +101,18 @@ function getConditionsSet(conditions) {
101	101	return getDefaultConditionsSet();
102	102	}
103	103
	104	+ /**
	105	+ * @typedef {{
	106	+ * [Symbol.toStringTag]: 'Module',
	107	+ * }} ModuleNamespaceObject
	108	+ */
	109	+
104	110	/**
105	111	* @callback ImportModuleDynamicallyCallback
106	112	* @param {string} specifier
107	113	* @param {ModuleWrap|ContextifyScript|Function|vm.Module} callbackReferrer
108	114	* @param {Record<string, string>} attributes
109		- * @returns { Promise<void> }
	115	+ * @returns {Promise<ModuleNamespaceObject>}
110	116	*/
111	117
112	118	/**

0 commit comments

Comments

0 (0)