http2: shrink default `vector::reserve()` allocations · nodejs/node@156f2f3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 156f2f3

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BethGriggs

committed

http2: shrink default vector::reserve() allocations

Allocating memory upfront comes with overhead, and in particular, `std::vector` implementations do not necessarily return memory to the system when one might expect that (e.g. after shrinking the vector). Backport-PR-URL: #29124 PR-URL: #29122 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 10f05b6 commit 156f2f3
Copy full SHA for 156f2f3

1 file changed

+5-4Lines changed: 5 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_http2.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc

+5-4Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -668,7 +668,7 @@ Http2Session::Http2Session(Environment* env,
668	668	// fails.
669	669	CHECK_EQ(fn(&session_, callbacks, this, *opts, *allocator_info), 0);
670	670
671		- outgoing_storage_.reserve(4096);
	671	+ outgoing_storage_.reserve(1024);
672	672	outgoing_buffers_.reserve(32);
673	673
674	674	{
@@ -1993,9 +1993,10 @@ Http2Stream::Http2Stream(
1993	1993
1994	1994	// Limit the number of header pairs
1995	1995	max_header_pairs_ = session->GetMaxHeaderPairs();
1996		- if (max_header_pairs_ == 0)
1997		- max_header_pairs_ = DEFAULT_MAX_HEADER_LIST_PAIRS;
1998		- current_headers_.reserve(max_header_pairs_);
	1996	+ if (max_header_pairs_ == 0) {
	1997	+ max_header_pairs_ = DEFAULT_MAX_HEADER_LIST_PAIRS;
	1998	+ }
	1999	+ current_headers_.reserve(std::min(max_header_pairs_, 12u));
1999	2000
2000	2001	// Limit the number of header octets
2001	2002	max_header_length_ =

0 commit comments

Comments

0 (0)