Commit 15c2de4
crypto: fix setEngine() when OPENSSL_NO_ENGINE set
When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently
throws an internal error because the C++ binding does not export the
relevant function, which causes _setEngine() to be undefined within JS.
Instead, match the behavior of tls/secure-context.js and throw the
existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL
has been configured with OPENSSL_NO_ENGINE.
PR-URL: #47977
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent ad2c05b commit 15c2de4
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -44,6 +44,7 @@ const normalizeHashName = require('internal/crypto/hashnames'); | |||
| 44 | 44 | const { | |
| 45 | 45 | hideStackFrames, | |
| 46 | 46 | codes: { | |
| 47 | + ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED, | ||
| 47 | 48 | ERR_CRYPTO_ENGINE_UNKNOWN, | |
| 48 | 49 | ERR_INVALID_ARG_TYPE, | |
| 49 | 50 | ERR_INVALID_ARG_VALUE, | |
@@ -105,6 +106,8 @@ function setEngine(id, flags) { | |||
| 105 | 106 | if (flags === 0) | |
| 106 | 107 | flags = ENGINE_METHOD_ALL; | |
| 107 | 108 | ||
| 109 | + if (typeof _setEngine !== 'function') | ||
| 110 | + throw new ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED(); | ||
| 108 | 111 | if (!_setEngine(id, flags)) | |
| 109 | 112 | throw new ERR_CRYPTO_ENGINE_UNKNOWN(id); | |
| 110 | 113 | } | |
0 commit comments