Commit 15c9208
build: set --v8-enable-object-print by default
The flag improves the experience of debugging V8 with native debuggers.
It doens't incur performance penality, the only downside is an increase
in binary size by approximately 248 Kb.
Ref: #32834
PR-URL: #34705
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>1 parent 6ee2578 commit 15c9208
2 files changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -54,6 +54,9 @@ | |||
| 54 | 54 | # Enable disassembler for `--print-code` v8 options | |
| 55 | 55 | 'v8_enable_disassembler': 1, | |
| 56 | 56 | ||
| 57 | + # Sets -dOBJECT_PRINT. | ||
| 58 | + 'v8_enable_object_print%': 1, | ||
| 59 | + | ||
| 57 | 60 | # https://github.com/nodejs/node/pull/22920/files#r222779926 | |
| 58 | 61 | 'v8_enable_handle_zapping': 0, | |
| 59 | 62 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -662,7 +662,7 @@ | |||
| 662 | 662 | parser.add_option('--v8-enable-object-print', | |
| 663 | 663 | action='store_true', | |
| 664 | 664 | dest='v8_enable_object_print', | |
| 665 | - default=False, | ||
| 665 | + default=True, | ||
| 666 | 666 | help='compile V8 with auxiliar functions for native debuggers') | |
| 667 | 667 | ||
| 668 | 668 | parser.add_option('--node-builtin-modules-path', | |
0 commit comments