Commit 166df9e
doc: remove squash guideline from onboarding doc
Although I agree with the guideline people should generally not squash
commits in a pull request until the end (in other words, until it's time
to land the PR), it is clear from comments and actions in the issue
tracker that many do not share that view. This is fine by me, but I do
think that we should our documentation should reflect our practices
rather than being an aspirational statement.
If we *do* wish to preserve this recommendation, it probably belongs in
another document anyway as this is not a recommendation for
Collaborators only but for anyone opening a pull request.
PR-URL: #20413
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 56c27c6 commit 166df9e
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -97,4 +97,3 @@ to update from nodejs/node: | |||
| 97 | 97 | ## Best practices | |
| 98 | 98 | ||
| 99 | 99 | * When making PRs, spend time writing a thorough description. | |
| 100 | - * Usually only squash at the end of your work. | ||
0 commit comments