test: add missing test coverage for setLocalAddress() · nodejs/node@16f6f1a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 16f6f1a

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: add missing test coverage for setLocalAddress()

Add missing coverage for setLocalAddress() method of dns.Resolver class. The case where a valid IPv4 argument was supplied along with an invalid IPv6 argument was not being checked. Refs: https://coverage.nodejs.org/coverage-85b42af4398073f8/lib/internal/dns/utils.js.html#L124 PR-URL: #36039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent ffaa114 commit 16f6f1a
Copy full SHA for 16f6f1a

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-dns-setlocaladdress.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-dns-setlocaladdress.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns-setlocaladdress.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,10 @@ const promiseResolver = new dns.promises.Resolver();
27	27	}, Error);
28	28	assert.throws(() => {
29	29	resolver.setLocalAddress(123);
30		- }, Error);
	30	+ }, { code: 'ERR_INVALID_ARG_TYPE' });
	31	+ assert.throws(() => {
	32	+ resolver.setLocalAddress('127.0.0.1', 42);
	33	+ }, { code: 'ERR_INVALID_ARG_TYPE' });
31	34	assert.throws(() => {
32	35	resolver.setLocalAddress();
33	36	}, Error);

0 commit comments

Comments

0 (0)