debugger: throw a more useful error when the frame is missing · nodejs/node@1702a80 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1702a80

Browse filesBrowse the repository at this point in the historyBrowse files

cola119

authored and

juanarbol

committed

debugger: throw a more useful error when the frame is missing

PR-URL: #42776 Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 026ae9d commit 1702a80
Copy full SHA for 1702a80

2 files changed

+33Lines changed: 33 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/debugger
  • inspect_repl.js
• test/sequential
  • test-debugger-list.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/debugger/inspect_repl.js‎

Copy file name to clipboardExpand all lines: lib/internal/debugger/inspect_repl.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -681,6 +681,9 @@ function createRepl(inspector) {
681	681
682	682	// List source code
683	683	function list(delta = 5) {
	684	+ if (!selectedFrame) {
	685	+ throw new ERR_DEBUGGER_ERROR('Requires execution to be paused');
	686	+ }
684	687	return selectedFrame.list(delta).then(null, (error) => {
685	688	print("You can't list source code right now");
686	689	throw error;

Collapse file

‎test/sequential/test-debugger-list.js‎

Copy file name to clipboard

+30Lines changed: 30 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,30 @@
	1	+ 'use strict';
	2	+ const common = require('../common');
	3	+
	4	+ common.skipIfInspectorDisabled();
	5	+
	6	+ const fixtures = require('../common/fixtures');
	7	+ const startCLI = require('../common/debugger');
	8	+
	9	+ const assert = require('assert');
	10	+
	11	+ const cli = startCLI([fixtures.path('debugger/three-lines.js')]);
	12	+
	13	+ (async () => {
	14	+ await cli.waitForInitialBreak();
	15	+ await cli.waitForPrompt();
	16	+ await cli.command('list(0)');
	17	+ assert.match(cli.output, /> 1 let x = 1;/);
	18	+ await cli.command('list(1)');
	19	+ assert.match(cli.output, /> 1 let x = 1;\r?\n {2}2 x = x \+ 1;/);
	20	+ await cli.command('list(10)');
	21	+ assert.match(cli.output, /> 1 let x = 1;\r?\n {2}2 x = x \+ 1;\r?\n {2}3 module\.exports = x;\r?\n {2}4 /);
	22	+ await cli.command('c');
	23	+ await cli.waitFor(/disconnect/);
	24	+ await cli.waitFor(/debug> $/);
	25	+ await cli.command('list()');
	26	+ await cli.waitFor(/ERR_DEBUGGER_ERROR/);
	27	+ assert.match(cli.output, /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/);
	28	+ })()
	29	+ .finally(() => cli.quit())
	30	+ .then(common.mustCall());

0 commit comments

Comments

0 (0)