lib: comment explaining special-case handling of promises · nodejs/node@1737352 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1737352

Browse filesBrowse the repository at this point in the historyBrowse files

Stephen Belanger

authored and

MylesBorins

committed

lib: comment explaining special-case handling of promises

Promise handling is special-cased for domains and trace_events. Domains must not add the `domain` property to promises in other contexts, and trace_events must be emitted from JavaScript as promises no longer have an AsyncWrap type attached to them. PR-URL: #39135 Backport-PR-URL: #39742 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

1 parent 5500ae9 commit 1737352
Copy full SHA for 1737352

2 files changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • domain.js
  • internal
    • trace_events_async_hooks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/domain.js‎

Copy file name to clipboardExpand all lines: lib/domain.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -74,6 +74,8 @@ const asyncHook = createHook({
74	74	if (process.domain !== null && process.domain !== undefined) {
75	75	// If this operation is created while in a domain, let's mark it
76	76	pairing.set(asyncId, process.domain[kWeak]);
	77	+ // Promises from other contexts, such as with the VM module, should not
	78	+ // have a domain property as it can be used to escape the sandbox.
77	79	if (type !== 'PROMISE' || resource instanceof Promise) {
78	80	ObjectDefineProperty(resource, 'domain', {
79	81	configurable: true,

Collapse file

‎lib/internal/trace_events_async_hooks.js‎

Copy file name to clipboardExpand all lines: lib/internal/trace_events_async_hooks.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -31,6 +31,8 @@ const kEnabled = Symbol('enabled');
31	31	// twice the async_wrap.Providers list is used to filter the events.
32	32	const nativeProviders = new SafeSet(ObjectKeys(async_wrap.Providers));
33	33	const typeMemory = new SafeMap();
	34	+
	35	+ // Promises are not AsyncWrap resources so they should emit trace_events here.
34	36	nativeProviders.delete('PROMISE');
35	37
36	38	function createHook() {

0 commit comments

Comments

0 (0)