Commit 173b088
inspector: do not prompt to use localhost
There are multiple reports of Windows7 not being able to resolve
localhost on some setups (web search also confirms that). This change
will advertise "127.0.0.1" as inspector host name.
Fixes: #9382
Fixes: #9188
PR-URL: #9451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0325339 commit 173b088
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ static const uint8_t PROTOCOL_JSON[] = { | |||
| 39 | 39 | ||
| 40 | 40 | std::string GetWsUrl(int port, const std::string& id) { | |
| 41 | 41 | char buf[1024]; | |
| 42 | - snprintf(buf, sizeof(buf), "localhost:%d/%s", port, id.c_str()); | ||
| 42 | + snprintf(buf, sizeof(buf), "127.0.0.1:%d/%s", port, id.c_str()); | ||
| 43 | 43 | return buf; | |
| 44 | 44 | } | |
| 45 | 45 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ function checkListResponse(err, response) { | |||
| 11 | 11 | assert.ok(response[0]['devtoolsFrontendUrl']); | |
| 12 | 12 | assert.ok( | |
| 13 | 13 | response[0]['webSocketDebuggerUrl'] | |
| 14 | - .match(/ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/)); | ||
| 14 | + .match(/ws:\/\/127.0.0.1:\d+\/[0-9A-Fa-f]{8}-/)); | ||
| 15 | 15 | } | |
| 16 | 16 | ||
| 17 | 17 | function checkVersion(err, response) { | |
0 commit comments