url: simplify constructor URLSearchParams. Remove needless check null · nodejs/node@1767ef0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1767ef0

Browse filesBrowse the repository at this point in the historyBrowse files

Connormiha

authored and

MylesBorins

committed

url: simplify constructor URLSearchParams. Remove needless check null

PR-URL: #18700 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent b5073a0 commit 1767ef0
Copy full SHA for 1767ef0

1 file changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • url.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/url.js‎

Copy file name to clipboardExpand all lines: lib/internal/url.js

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -98,8 +98,7 @@ class URLSearchParams {
98	98	constructor(init = undefined) {
99	99	if (init === null || init === undefined) {
100	100	this[searchParams] = [];
101		- } else if ((typeof init === 'object' && init !== null) ||
102		- typeof init === 'function') {
	101	+ } else if (typeof init === 'object' || typeof init === 'function') {
103	102	const method = init[Symbol.iterator];
104	103	if (method === this[Symbol.iterator]) {
105	104	// While the spec does not have this branch, we can use it as a

0 commit comments

Comments

0 (0)