Commit 182c73b
committed
http2: switch to new runtime-controlled debugging system
Remove `--debug-http2` as a compile-time feature and
make all debug statements available using `NODE_DEBUG_NATIVE=http2`
at runtime.
This probably makes the debugging-enabled case a bit slower due to
additional string concatenations, but switching to a runtime-checking
system makes debugging more flexible and can be applied more easily
to other parts of the source code as well.
PR-URL: #20987
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 45eeea4 commit 182c73b
6 files changed
Lines changed: 115 additions & 154 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -443,11 +443,6 @@ parser.add_option('--debug-lib', | |||
| 443 | 443 | dest='node_debug_lib', | |
| 444 | 444 | help='build lib with DCHECK macros') | |
| 445 | 445 | ||
| 446 | - http2_optgroup.add_option('--debug-http2', | ||
| 447 | - action='store_true', | ||
| 448 | - dest='debug_http2', | ||
| 449 | - help='build with http2 debug statements on (default is false)') | ||
| 450 | - | ||
| 451 | 446 | http2_optgroup.add_option('--debug-nghttp2', | |
| 452 | 447 | action='store_true', | |
| 453 | 448 | dest='debug_nghttp2', | |
@@ -970,11 +965,6 @@ def configure_node(o): | |||
| 970 | 965 | ||
| 971 | 966 | o['variables']['node_debug_lib'] = b(options.node_debug_lib) | |
| 972 | 967 | ||
| 973 | - if options.debug_http2: | ||
| 974 | - o['variables']['debug_http2'] = 1 | ||
| 975 | - else: | ||
| 976 | - o['variables']['debug_http2'] = 'false' | ||
| 977 | - | ||
| 978 | 968 | if options.debug_nghttp2: | |
| 979 | 969 | o['variables']['debug_nghttp2'] = 1 | |
| 980 | 970 | else: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -90,10 +90,6 @@ | |||
| 90 | 90 | 'NODE_RELEASE_URLBASE="<(node_release_urlbase)"', | |
| 91 | 91 | ] | |
| 92 | 92 | }], | |
| 93 | - [ | ||
| 94 | - 'debug_http2==1', { | ||
| 95 | - 'defines': [ 'NODE_DEBUG_HTTP2=1' ] | ||
| 96 | - }], | ||
| 97 | 93 | [ 'v8_enable_i18n_support==1', { | |
| 98 | 94 | 'defines': [ 'NODE_HAVE_I18N_SUPPORT=1' ], | |
| 99 | 95 | 'dependencies': [ | |
0 commit comments