FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: improve consistency between workflows · nodejs/node@182e6b9 · GitHub

/ node Public

Commit 182e6b9

Browse files
Mesteery
authored and
bengl
committed
build: improve consistency between workflows
PR-URL: #41791 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 3243701 commit 182e6b9

17 files changed

Lines changed: 35 additions & 44 deletions

‎.github/workflows/authors.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "authors update"
1+
name: Authors update
22
on:
33
schedule:
44
# Run once a week at 00:05 AM UTC on Sunday.

‎.github/workflows/auto-start-ci.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ env:
1212
NODE_VERSION: lts/*
1313

1414
jobs:
15-
get_prs_for_ci:
15+
get-prs-for-ci:
1616
if: github.repository == 'nodejs/node'
1717
runs-on: ubuntu-latest
1818
outputs:
@@ -29,20 +29,20 @@ jobs:
2929
--limit 100
3030
env:
3131
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
32-
startCI:
33-
needs: get_prs_for_ci
34-
if: needs.get_prs_for_ci.outputs.numbers != ''
32+
start-ci:
33+
needs: get-prs-for-ci
34+
if: needs.get-prs-for-ci.outputs.numbers != ''
3535
runs-on: ubuntu-latest
3636
steps:
3737
- uses: actions/checkout@v2
3838
with:
3939
persist-credentials: false
4040

41-
# Install dependencies
4241
- name: Install Node.js
4342
uses: actions/setup-node@v2
4443
with:
4544
node-version: ${{ env.NODE_VERSION }}
45+
4646
- name: Install node-core-utils
4747
run: npm install -g node-core-utils
4848

@@ -55,6 +55,6 @@ jobs:
5555
ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
5656
5757
- name: Start the CI
58-
run: ./tools/actions/start-ci.sh ${{ needs.get_prs_for_ci.outputs.numbers }}
58+
run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
5959
env:
6060
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

‎.github/workflows/build-tarball.yml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,12 @@ on:
2525
- '!.github/workflows/build-tarball.yml'
2626

2727
env:
28+
PYTHON_VERSION: '3.10'
2829
FLAKY_TESTS: dontcare
2930

3031
jobs:
3132
build-tarball:
3233
if: github.event.pull_request.draft == false
33-
env:
34-
PYTHON_VERSION: '3.10'
3534
runs-on: ubuntu-latest
3635
steps:
3736
- uses: actions/checkout@v2
@@ -57,8 +56,6 @@ jobs:
5756
name: tarballs
5857
path: tarballs
5958
test-tarball-linux:
60-
env:
61-
PYTHON_VERSION: '3.10'
6259
needs: build-tarball
6360
runs-on: ubuntu-latest
6461
steps:

‎.github/workflows/build-windows.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
name: build-windows
1+
name: Build Windows
22

33
on:
44
pull_request:
55
paths-ignore:
6-
- "README.md"
6+
- README.md
77
- .github/**
88
- '!.github/workflows/build-windows.yml'
99
types: [opened, synchronize, reopened, ready_for_review]
@@ -15,7 +15,7 @@ on:
1515
- v[0-9]+.x-staging
1616
- v[0-9]+.x
1717
paths-ignore:
18-
- "README.md"
18+
- README.md
1919
- .github/**
2020
- '!.github/workflows/build-windows.yml'
2121

‎.github/workflows/comment-labeled.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Comment on issues and PRs when labelled
1+
name: Comment on issues and PRs when labeled
22
on:
33
issues:
44
types: [labeled]
@@ -12,7 +12,7 @@ env:
1212
FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.
1313

1414
jobs:
15-
staleComment:
15+
stale-comment:
1616
if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
1717
runs-on: ubuntu-latest
1818
steps:
@@ -22,8 +22,8 @@ jobs:
2222
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2323
run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
2424

25-
fastTrack:
26-
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
25+
fast-track:
26+
if: github.repository == 'nodejs/node' && github.event.issue.pull_request && github.event.label.name == 'fast-track'
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Request Fast-Track

‎.github/workflows/commit-lint.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q"
1+
name: First commit message adheres to guidelines at https://goo.gl/p2fr5Q
22

33
on: [pull_request]
44

‎.github/workflows/coverage-linux.yml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: coverage-linux
1+
name: Coverage Linux
22

33
on:
44
pull_request:
@@ -11,9 +11,7 @@ on:
1111
- .github/**
1212
- '!.github/workflows/coverage-linux.yml'
1313
push:
14-
branches:
15-
- master
16-
- main
14+
branches: [master, main]
1715
paths-ignore:
1816
- '**.md'
1917
- 'benchmark/**'

‎.github/workflows/coverage-windows.yml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: coverage-windows
1+
name: Coverage Windows
22

33
on:
44
pull_request:
@@ -12,9 +12,7 @@ on:
1212
- .github/**
1313
- '!.github/workflows/coverage-windows.yml'
1414
push:
15-
branches:
16-
- master
17-
- main
15+
branches: [master, main]
1816
paths-ignore:
1917
- '**.md'
2018
- 'benchmark/**'

.github/workflows/misc.yml renamed to .github/workflows/doc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: misc
1+
name: Test and upload documentation to artifacts
22

33
on:
44
pull_request:

‎.github/workflows/license-builder.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: license update
1+
name: License update
22
on:
33
schedule:
44
# 00:00:00 every Monday

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL