test_runner: set non-zero exit code when suite errors occur · nodejs/node@1865691 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1865691

Browse filesBrowse the repository at this point in the historyBrowse files

geeksilva97

authored and

aduh95

committed

test_runner: set non-zero exit code when suite errors occur

PR-URL: #62282 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

1 parent ede52bc commit 1865691
Copy full SHA for 1865691

3 files changed

+21Lines changed: 21 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner
  • utils.js
• test
  • fixtures/test-runner
    • describe_error.js
  • parallel
    • test-runner-exit-code.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/utils.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/utils.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -384,6 +384,9 @@ function countCompletedTest(test, harness = test.root.harness) {
384	384	}
385	385	if (test.reportedType === 'suite') {
386	386	harness.counters.suites++;
	387	+ if (!test.passed) {
	388	+ harness.success = false;
	389	+ }
387	390	return;
388	391	}
389	392	// Check SKIP and TODO tests first, as those should not be counted as

Collapse file

‎test/fixtures/test-runner/describe_error.js‎

Copy file name to clipboard

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,10 @@
	1	+ 'use strict';
	2	+ const { describe, it } = require('node:test');
	3	+
	4	+ describe('should fail', () => {
	5	+ throw new Error('error in describe');
	6	+ });
	7	+
	8	+ describe('should pass', () => {
	9	+ it('ok', () => {});
	10	+ });

Collapse file

‎test/parallel/test-runner-exit-code.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-runner-exit-code.js

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -70,6 +70,14 @@ if (process.argv[2] === 'child') {
70	70	assert.strictEqual(child.status, 1);
71	71	assert.strictEqual(child.signal, null);
72	72
	73	+ // An error thrown inside describe() should cause a non-zero exit code.
	74	+ child = spawnSync(process.execPath, [
	75	+ '--test',
	76	+ fixtures.path('test-runner', 'describe_error.js'),
	77	+ ]);
	78	+ assert.strictEqual(child.status, 1);
	79	+ assert.strictEqual(child.signal, null);
	80	+
73	81	// With process isolation (default), the test name shown is the file path
74	82	// because the parent runner only knows about file-level tests
75	83	const neverEndingSync = fixtures.path('test-runner', 'never_ending_sync.js');

0 commit comments

Comments

0 (0)