test: refactored test-http-response-splitting to use countdown · nodejs/node@1866b05 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1866b05

Browse filesBrowse the repository at this point in the historyBrowse files

mithunsasidharan

authored and

MylesBorins

committed

test: refactored test-http-response-splitting to use countdown

PR-URL: #17348 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

1 parent ee1c95f commit 1866b05
Copy full SHA for 1866b05

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-response-splitting.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-response-splitting.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-response-splitting.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -5,6 +5,7 @@ const http = require('http');
5	5	const net = require('net');
6	6	const url = require('url');
7	7	const assert = require('assert');
	8	+ const Countdown = require('../common/countdown');
8	9
9	10	// Response splitting example, credit: Amit Klein, Safebreach
10	11	const str = '/welcome?lang=bar%c4%8d%c4%8aContent­Length:%200%c4%8d%c4%8a%c' +
@@ -18,6 +19,7 @@ const x = 'fooഊSet-Cookie: foo=barഊഊ<script>alert("Hi!")</script>';
18	19	const y = 'foo⠊Set-Cookie: foo=bar';
19	20
20	21	let count = 0;
	22	+ const countdown = new Countdown(3, () => server.close());
21	23
22	24	function test(res, code, key, value) {
23	25	const header = { [key]: value };
@@ -46,8 +48,7 @@ const server = http.createServer((req, res) => {
46	48	default:
47	49	assert.fail('should not get to here.');
48	50	}
49		- if (count === 3)
50		- server.close();
	51	+ countdown.dec();
51	52	res.end('ok');
52	53	});
53	54	server.listen(0, () => {

0 commit comments

Comments

0 (0)