Commit 189270d
src: fix coverity report
Fix coverity report about possibly dereferencing
a null. If the the buffer.data != nullptr
check indicates that the buffer was null, then
relying on the value in buffer_size is no longer
safe. The later call to uv_pipe_getpeername
depends on the buffer_size being correct to
avoid deferencing buffer.data if it is not
big enough.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42663
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0654d3f commit 189270d
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -95,6 +95,8 @@ static void ReportPipeEndpoints(uv_handle_t* h, JSONWriter* writer) { | |||
| 95 | 95 | buffer = MallocedBuffer<char>(buffer_size); | |
| 96 | 96 | if (buffer.data != nullptr) { | |
| 97 | 97 | rc = uv_pipe_getsockname(&handle->pipe, buffer.data, &buffer_size); | |
| 98 | + } else { | ||
| 99 | + buffer_size = 0; | ||
| 98 | 100 | } | |
| 99 | 101 | } | |
| 100 | 102 | if (rc == 0 && buffer_size != 0 && buffer.data != nullptr) { | |
0 commit comments