Commit 18c4e5e
test: remove message from assert.strictEqual()
Converted the 'message' argument values from the last two free socket
assert.strictEqual() calls to code comments as they fail to provide the
necessary details and values specific to why the test is failing. The
default message returned from the strictEqual() call should provide
sufficient details for debugging errors.
PR-URL: #19525
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 146c488 commit 18c4e5e
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,8 +27,8 @@ server.listen(0, () => { | |||
| 27 | 27 | res.on('end', common.mustCall(() => { | |
| 28 | 28 | process.nextTick(common.mustCall(() => { | |
| 29 | 29 | const freeSockets = agent.freeSockets[socketKey]; | |
| 30 | - assert.strictEqual(freeSockets.length, 1, | ||
| 31 | - `expect a free socket on ${socketKey}`); | ||
| 30 | + //expect a free socket on socketKey | ||
| 31 | + assert.strictEqual(freeSockets.length, 1); | ||
| 32 | 32 | ||
| 33 | 33 | //generate a random error on the free socket | |
| 34 | 34 | const freeSocket = freeSockets[0]; | |
@@ -40,8 +40,8 @@ server.listen(0, () => { | |||
| 40 | 40 | })); | |
| 41 | 41 | ||
| 42 | 42 | function done() { | |
| 43 | - assert.strictEqual(Object.keys(agent.freeSockets).length, 0, | ||
| 44 | - 'expect the freeSockets pool to be empty'); | ||
| 43 | + //expect the freeSockets pool to be empty | ||
| 44 | + assert.strictEqual(Object.keys(agent.freeSockets).length, 0); | ||
| 45 | 45 | ||
| 46 | 46 | agent.destroy(); | |
| 47 | 47 | server.close(); | |
0 commit comments