Commit 18e00a5
committed
test: deflake test-http-regr-gh-2928
Hard code the value of the host parameter to `common.localhostIPv4` in
`server.listen()` and `net.connect()`. This
1. ensures that the client `socket._handle` is not reinitialized during
connection due to the family autodetection algorithm, preventing
`parser.consume()` from being called with an invalid `socket._handle`
parameter.
2. works around an issue in the FreeBSD 12 machine where the stress test
is run where some sockets get stuck after connection.
PR-URL: #49574
Closes: #49565
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b651e37 commit 18e00a5
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,7 +25,7 @@ function execAndClose() { | |||
| 25 | 25 | const parser = parsers.pop(); | |
| 26 | 26 | parser.initialize(HTTPParser.RESPONSE, {}); | |
| 27 | 27 | ||
| 28 | - const socket = net.connect(common.PORT); | ||
| 28 | + const socket = net.connect(common.PORT, common.localhostIPv4); | ||
| 29 | 29 | socket.on('error', (e) => { | |
| 30 | 30 | // If SmartOS and ECONNREFUSED, then retry. See | |
| 31 | 31 | // https://github.com/nodejs/node/issues/2663. | |
@@ -57,7 +57,7 @@ const server = net.createServer(function(c) { | |||
| 57 | 57 | c.end('HTTP/1.1 200 OK\r\n\r\n', function() { | |
| 58 | 58 | c.destroySoon(); | |
| 59 | 59 | }); | |
| 60 | - }).listen(common.PORT, execAndClose); | ||
| 60 | + }).listen(common.PORT, common.localhostIPv4, execAndClose); | ||
| 61 | 61 | ||
| 62 | 62 | process.on('exit', function() { | |
| 63 | 63 | assert.strictEqual(gotResponses, COUNT); | |
0 commit comments