Commit 1918b4e
test: correct header length subtraction
In test-http-max-http-headers, a comment asks why we are subtracting 32
from the length of the invalid-length-by-1 headers instead of just 1.
Subtracting 1 seems to be correct and works.
PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 1222be8 commit 1918b4e
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,8 +37,7 @@ function fillHeaders(headers, currentSize, valid = false) { | |||
| 37 | 37 | ||
| 38 | 38 | // Generate valid headers | |
| 39 | 39 | if (valid) { | |
| 40 | - // TODO(mcollina): understand why -32 is needed instead of -1 | ||
| 41 | - headers = headers.slice(0, -32); | ||
| 40 | + headers = headers.slice(0, -1); | ||
| 42 | 41 | } | |
| 43 | 42 | return headers + '\r\n\r\n'; | |
| 44 | 43 | } | |
0 commit comments