test: remove common.PORT from test-net-write-callbacks.js · nodejs/node@1933efa · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1933efa

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

codebytere

committed

test: remove common.PORT from test-net-write-callbacks.js

Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: #31839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

1 parent f2389eb commit 1933efa
Copy full SHA for 1933efa

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/pummel
  • test-net-write-callbacks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/pummel/test-net-write-callbacks.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-net-write-callbacks.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -20,7 +20,7 @@
20	20	// USE OR OTHER DEALINGS IN THE SOFTWARE.
21	21
22	22	'use strict';
23		- const common = require('../common');
	23	+ require('../common');
24	24	const net = require('net');
25	25	const assert = require('assert');
26	26
@@ -55,8 +55,8 @@ function makeCallback(c) {
55	55	};
56	56	}
57	57
58		- server.listen(common.PORT, function() {
59		- const client = net.createConnection(common.PORT);
	58	+ server.listen(0, function() {
	59	+ const client = net.createConnection(server.address().port);
60	60
61	61	client.on('connect', function() {
62	62	for (let i = 0; i < N; i++) {

0 commit comments

Comments

0 (0)