Commit 197b616
test: add an indicator isIBMi
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.
PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 3b096c2 commit 197b616
4 files changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -237,6 +237,11 @@ Attempts to 'kill' `pid` | |||
| 237 | 237 | ||
| 238 | 238 | Platform check for Free BSD. | |
| 239 | 239 | ||
| 240 | + ### isIBMi | ||
| 241 | + * [<boolean>][] | ||
| 242 | + | ||
| 243 | + Platform check for IBMi. | ||
| 244 | + | ||
| 240 | 245 | ### isLinux | |
| 241 | 246 | * [<boolean>][] | |
| 242 | 247 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -102,6 +102,9 @@ if (process.argv.length === 2 && | |||
| 102 | 102 | ||
| 103 | 103 | const isWindows = process.platform === 'win32'; | |
| 104 | 104 | const isAIX = process.platform === 'aix'; | |
| 105 | + // On IBMi, process.platform and os.platform() both return 'aix', | ||
| 106 | + // It is not enough to differentiate between IBMi and real AIX system. | ||
| 107 | + const isIBMi = os.type() === 'OS400'; | ||
| 105 | 108 | const isLinuxPPCBE = (process.platform === 'linux') && | |
| 106 | 109 | (process.arch === 'ppc64') && | |
| 107 | 110 | (os.endianness() === 'BE'); | |
@@ -762,6 +765,7 @@ module.exports = { | |||
| 762 | 765 | isAIX, | |
| 763 | 766 | isAlive, | |
| 764 | 767 | isFreeBSD, | |
| 768 | + isIBMi, | ||
| 765 | 769 | isLinux, | |
| 766 | 770 | isLinuxPPCBE, | |
| 767 | 771 | isMainThread, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,6 +10,7 @@ const { | |||
| 10 | 10 | isMainThread, | |
| 11 | 11 | isWindows, | |
| 12 | 12 | isAIX, | |
| 13 | + isIBMi, | ||
| 13 | 14 | isLinuxPPCBE, | |
| 14 | 15 | isSunOS, | |
| 15 | 16 | isFreeBSD, | |
@@ -56,6 +57,7 @@ export { | |||
| 56 | 57 | isMainThread, | |
| 57 | 58 | isWindows, | |
| 58 | 59 | isAIX, | |
| 60 | + isIBMi, | ||
| 59 | 61 | isLinuxPPCBE, | |
| 60 | 62 | isSunOS, | |
| 61 | 63 | isFreeBSD, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,6 +26,9 @@ const common = require('../common'); | |||
| 26 | 26 | if (common.isOSX) | |
| 27 | 27 | common.skip('macOS may allow ordinary processes to use any port'); | |
| 28 | 28 | ||
| 29 | + if (common.isIBMi) | ||
| 30 | + common.skip('IBMi may allow ordinary processes to use any port'); | ||
| 31 | + | ||
| 29 | 32 | if (common.isWindows) | |
| 30 | 33 | common.skip('not reliable on Windows.'); | |
| 31 | 34 | ||
0 commit comments