test: use random port in NodeInstance.startViaSignal() · nodejs/node@1a78632 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1a78632

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

RafaelGSS

committed

test: use random port in NodeInstance.startViaSignal()

Which makes it possible to run the tests that use this in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 7d2d40e commit 1a78632
Copy full SHA for 1a78632

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/common
  • inspector-helper.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/inspector-helper.js‎

Copy file name to clipboardExpand all lines: test/common/inspector-helper.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -372,7 +372,7 @@ class NodeInstance extends EventEmitter {
372	372
373	373	static async startViaSignal(scriptContents) {
374	374	const instance = new NodeInstance(
375		- ['--expose-internals'],
	375	+ ['--expose-internals', '--inspect-port=0'],
376	376	`${scriptContents}\nprocess._rawDebug('started');`, undefined);
377	377	const msg = 'Timed out waiting for process to start';
378	378	while (await fires(instance.nextStderrString(), msg, TIMEOUT) !== 'started');

0 commit comments

Comments

0 (0)