Commit 1abada9
committed
tools: avoid building twice in coverage jobs
PR-URL: #61899
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent f260e40 commit 1abada9
2 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -65,11 +65,11 @@ jobs: | |||
| 65 | 65 | run: npx envinfo | |
| 66 | 66 | - name: Install gcovr | |
| 67 | 67 | run: pip install gcovr==7.2 | |
| 68 | - - name: Build | ||
| 69 | - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl" | ||
| 68 | + - name: Configure | ||
| 69 | + run: ./configure --verbose --error-on-warn --coverage --without-intl | ||
| 70 | 70 | # TODO(bcoe): fix the couple tests that fail with the inspector enabled. | |
| 71 | 71 | # The cause is most likely coverage's use of the inspector. | |
| 72 | - - name: Test | ||
| 72 | + - name: Build and test | ||
| 73 | 73 | run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 | |
| 74 | 74 | - name: Report JS | |
| 75 | 75 | run: npx c8 report --check-coverage | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -65,11 +65,11 @@ jobs: | |||
| 65 | 65 | run: npx envinfo | |
| 66 | 66 | - name: Install gcovr | |
| 67 | 67 | run: pip install gcovr==7.2 | |
| 68 | - - name: Build | ||
| 69 | - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage" | ||
| 68 | + - name: Configure | ||
| 69 | + run: ./configure --verbose --error-on-warn --coverage | ||
| 70 | 70 | # TODO(bcoe): fix the couple tests that fail with the inspector enabled. | |
| 71 | 71 | # The cause is most likely coverage's use of the inspector. | |
| 72 | - - name: Test | ||
| 72 | + - name: Build and test | ||
| 73 | 73 | run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 | |
| 74 | 74 | - name: Report JS | |
| 75 | 75 | run: npx c8 report --check-coverage | |
0 commit comments