src: enable stack trace printing for V8 check failures · nodejs/node@1b04e67 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1b04e67

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BethGriggs

committed

src: enable stack trace printing for V8 check failures

Example output: $ ./node --expose-gc test/addons/buffer-free-callback/test.js # # Fatal error in , line 0 # Check failed: result.second. # # # #FailureMessage Object: 0x7ffebd956860 1: 0x56290a45b105 [./node] 2: 0x56290b305b77 V8_Fatal(char const*, ...) [./node] 3: 0x56290a82702d v8::internal::GlobalBackingStoreRegistry::Register(std::shared_ptr<v8::internal::BackingStore>) [./node] 4: 0x56290a59a1de v8::ArrayBuffer::GetBackingStore() [./node] 5: 0x56290a3cb63f node::Buffer::New(node::Environment*, char*, unsigned long, void (*)(char*, void*), void*) [./node] 6: 0x56290a3cbcdc node::Buffer::New(v8::Isolate*, char*, unsigned long, void (*)(char*, void*), void*) [./node] 7: 0x7fdeabdfdf89 Alloc(v8::FunctionCallbackInfo<v8::Value> const&) [/home/xxxx/src/node/master/test/addons/buffer-free-callback/build/Release/binding.node] 8: 0x56290a5ca077 [./node] 9: 0x56290a5cbf97 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [./node] 10: 0x56290ad99539 [./node] Illegal instruction (core dumped) PR-URL: #31079 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 7cad756 commit 1b04e67
Copy full SHA for 1b04e67

2 files changed

+10Lines changed: 10 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_platform.cc
  • node_platform.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_platform.cc‎

Copy file name to clipboardExpand all lines: src/node_platform.cc

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -485,6 +485,14 @@ TracingController* NodePlatform::GetTracingController() {
485	485	return tracing_controller_;
486	486	}
487	487
	488	+ Platform::StackTracePrinter NodePlatform::GetStackTracePrinter() {
	489	+ return []() {
	490	+ fprintf(stderr, "\n");
	491	+ DumpBacktrace(stderr);
	492	+ fflush(stderr);
	493	+ };
	494	+ }
	495	+
488	496	template <class T>
489	497	TaskQueue<T>::TaskQueue()
490	498	: lock_(), tasks_available_(), tasks_drained_(),

Collapse file

‎src/node_platform.h‎

Copy file name to clipboardExpand all lines: src/node_platform.h

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -169,6 +169,8 @@ class NodePlatform : public MultiIsolatePlatform {
169	169	std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
170	170	v8::Isolate* isolate) override;
171	171
	172	+ Platform::StackTracePrinter GetStackTracePrinter() override;
	173	+
172	174	private:
173	175	std::shared_ptr<PerIsolatePlatformData> ForIsolate(v8::Isolate* isolate);
174	176

0 commit comments

Comments

0 (0)