doc: use number which is bigger than 1024 as port in http2 · nodejs/node@1b555ae · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1b555ae

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

targos

committed

doc: use number which is bigger than 1024 as port in http2

With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2. PR-URL: #46938 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 8723844 commit 1b555ae
Copy full SHA for 1b555ae

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • http2.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/http2.md‎

Copy file name to clipboardExpand all lines: doc/api/http2.md

+3-3Lines changed: 3 additions & 3 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -354,7 +354,7 @@ server.on('stream', (stream, headers) => {
354	354	stream.end('<h1>Hello World</h1>');
355	355	});
356	356
357		- server.listen(80);
	357	+ server.listen(8000);
358	358	```
359	359
360	360	Even though HTTP/2 streams and network sockets are not in a 1:1 correspondence,
@@ -2532,7 +2532,7 @@ server.on('stream', (stream, headers) => {
2532	2532	stream.end('<h1>Hello World</h1>');
2533	2533	});
2534	2534
2535		- server.listen(80);
	2535	+ server.listen(8000);
2536	2536	```
2537	2537
2538	2538	### `http2.createSecureServer(options[, onRequestHandler])`
@@ -2673,7 +2673,7 @@ server.on('stream', (stream, headers) => {
2673	2673	stream.end('<h1>Hello World</h1>');
2674	2674	});
2675	2675
2676		- server.listen(80);
	2676	+ server.listen(8443);
2677	2677	```
2678	2678
2679	2679	### `http2.connect(authority[, options][, listener])`

0 commit comments

Comments

0 (0)