Commit 1bb2967
http: fix non-string header value concatenation
Since headers are stored in an empty literal object ({}) instead
of an object created with Object.create(null), care must be taken
with property names inherited from Object. Currently there are
only functions inherited, so we can safely check for existing
strings instead.
Fixes: #4456
PR-URL: #4460
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>1 parent 437d0e3 commit 1bb2967
2 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,7 +159,7 @@ IncomingMessage.prototype._addHeaderLine = function(field, value, dest) { | |||
| 159 | 159 | ||
| 160 | 160 | default: | |
| 161 | 161 | // make comma-separated list | |
| 162 | - if (dest[field] !== undefined) { | ||
| 162 | + if (typeof dest[field] === 'string') { | ||
| 163 | 163 | dest[field] += ', ' + value; | |
| 164 | 164 | } else { | |
| 165 | 165 | dest[field] = value; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,6 +16,7 @@ var srv = http.createServer(function(req, res) { | |||
| 16 | 16 | assert.equal(req.headers['x-bar'], 'banjo, bango'); | |
| 17 | 17 | assert.equal(req.headers['sec-websocket-protocol'], 'chat, share'); | |
| 18 | 18 | assert.equal(req.headers['sec-websocket-extensions'], 'foo; 1, bar; 2, baz'); | |
| 19 | + assert.equal(req.headers['constructor'], 'foo, bar, baz'); | ||
| 19 | 20 | ||
| 20 | 21 | res.writeHead(200, {'Content-Type' : 'text/plain'}); | |
| 21 | 22 | res.end('EOF'); | |
@@ -48,7 +49,10 @@ srv.listen(common.PORT, function() { | |||
| 48 | 49 | ['sec-websocket-protocol', 'share'], | |
| 49 | 50 | ['sec-websocket-extensions', 'foo; 1'], | |
| 50 | 51 | ['sec-websocket-extensions', 'bar; 2'], | |
| 51 | - ['sec-websocket-extensions', 'baz'] | ||
| 52 | + ['sec-websocket-extensions', 'baz'], | ||
| 53 | + ['constructor', 'foo'], | ||
| 54 | + ['constructor', 'bar'], | ||
| 55 | + ['constructor', 'baz'], | ||
| 52 | 56 | ] | |
| 53 | 57 | }); | |
| 54 | 58 | }); | |
0 commit comments