test: fix flaky addons/callback-scope/test-resolve-async · nodejs/node@1ce9416 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1ce9416

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

targos

committed

test: fix flaky addons/callback-scope/test-resolve-async

Fixes: #22668 PR-URL: #22664 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent 2b49b43 commit 1ce9416
Copy full SHA for 1ce9416

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/addons/callback-scope
  • test-resolve-async.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/addons/callback-scope/test-resolve-async.js‎

Copy file name to clipboardExpand all lines: test/addons/callback-scope/test-resolve-async.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -4,7 +4,9 @@ const common = require('../../common');
4	4	const assert = require('assert');
5	5	const { testResolveAsync } = require(`./build/${common.buildType}/binding`);
6	6
	7	+ // Checks that resolving promises from C++ works.
	8	+
7	9	let called = false;
8	10	testResolveAsync().then(() => { called = true; });
9	11
10		- setTimeout(() => { assert(called); }, common.platformTimeout(50));
	12	+ process.on('beforeExit', () => { assert(called); });

0 commit comments

Comments

0 (0)