lib: refactor to use validateFunction in diagnostics_channel · nodejs/node@1cf087d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1cf087d

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

targos

committed

lib: refactor to use validateFunction in diagnostics_channel

Use validateFunction to remove duplicate implementation. PR-URL: #50955 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

1 parent bed1b93 commit 1cf087d
Copy full SHA for 1cf087d

1 file changed

+1-3Lines changed: 1 addition & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • diagnostics_channel.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/diagnostics_channel.js‎

Copy file name to clipboardExpand all lines: lib/diagnostics_channel.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -381,9 +381,7 @@ class TracingChannel {
381	381	}
382	382
383	383	const callback = ArrayPrototypeAt(args, position);
384		- if (typeof callback !== 'function') {
385		- throw new ERR_INVALID_ARG_TYPE('callback', ['function'], callback);
386		- }
	384	+ validateFunction(callback, 'callback');
387	385	ArrayPrototypeSplice(args, position, 1, wrappedCallback);
388	386
389	387	return start.runStores(context, () => {

0 commit comments

Comments

0 (0)