Commit 1cfa98c
committed
deps: V8: cherry-pick c721203
Original commit message:
Add missing null condition in Proxy GetPrototypeof
Bug: v8:9781
Change-Id: I1f82a828f103cc2aa3f9553214f6b4867ffc3b17
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829897
Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64049}
Refs: v8/v8@c721203
Fixes: #29730
PR-URL: #30065
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent edfbee3 commit 1cfa98c
3 files changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | 40 | # Reset this number to 0 on major V8 upgrades. | |
| 41 | 41 | # Increment by one for each non-official patch applied to deps/v8. | |
| 42 | - 'v8_embedder_string': '-node.15', | ||
| 42 | + 'v8_embedder_string': '-node.16', | ||
| 43 | 43 | ||
| 44 | 44 | ##### V8 defaults for Node.js ##### | |
| 45 | 45 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,7 +33,7 @@ namespace proxy { | |||
| 33 | 33 | ||
| 34 | 34 | // 8. If Type(handlerProto) is neither Object nor Null, throw a TypeError | |
| 35 | 35 | // exception. | |
| 36 | - if (!Is<JSReceiver>(handlerProto)) { | ||
| 36 | + if (!Is<JSReceiver>(handlerProto) && handlerProto != Null) { | ||
| 37 | 37 | goto ThrowProxyGetPrototypeOfInvalid; | |
| 38 | 38 | } | |
| 39 | 39 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,11 @@ | |||
| 1 | + // Copyright 2019 the V8 project authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + var proto = Object.getPrototypeOf(new Proxy(Object.create(null), { | ||
| 6 | + getPrototypeOf(target) { | ||
| 7 | + return Reflect.getPrototypeOf(target); | ||
| 8 | + } | ||
| 9 | + } )); | ||
| 10 | + | ||
| 11 | + assertEquals(proto, null); | ||
0 commit comments