src: remove outdated `Neuter()` call in `node_buffer.cc` · nodejs/node@1d2d3f3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 639
• Pull requests 566
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1d2d3f3

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BethGriggs

committed

src: remove outdated Neuter() call in node_buffer.cc

This call was introduced in 827ee49 to avoid a crash in a later `Neuter()` call that has later been removed in ebbbc5a, rendering the original call unnecessary. Refs: #3624 Refs: #5204 PR-URL: #25479 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

1 parent 326634c commit 1d2d3f3
Copy full SHA for 1d2d3f3

1 file changed

-5Lines changed: 0 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_buffer.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc

-5Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -392,11 +392,6 @@ MaybeLocal<Object> New(Environment* env,
392	392	}
393	393
394	394	Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), data, length);
395		- // `Neuter()`ing is required here to prevent materialization of the backing
396		- // store in v8. `nullptr` buffers are not writable, so this is semantically
397		- // correct.
398		- if (data == nullptr)
399		- ab->Neuter();
400	395	MaybeLocal<Uint8Array> ui = Buffer::New(env, ab, 0, length);
401	396
402	397	if (ui.IsEmpty()) {

0 commit comments

Comments

0 (0)