test: log errors in test-http2-propagate-session-destroy-code · nodejs/node@1d3405b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1d3405b

Browse filesBrowse the repository at this point in the historyBrowse files

lundibundi

authored and

BethGriggs

committed

test: log errors in test-http2-propagate-session-destroy-code

PR-URL: #31072 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent ddad6eb commit 1d3405b
Copy full SHA for 1d3405b

1 file changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http2-propagate-session-destroy-code.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http2-propagate-session-destroy-code.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http2-propagate-session-destroy-code.js

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -15,16 +15,16 @@ server.on('error', common.mustNotCall());
15	15	server.on('session', (session) => {
16	16	session.on('close', common.mustCall());
17	17	session.on('error', common.mustCall((err) => {
18		- assert(errRegEx.test(err));
	18	+ assert.ok(errRegEx.test(err), `server session err: ${err}`);
19	19	assert.strictEqual(session.closed, false);
20	20	assert.strictEqual(session.destroyed, true);
21	21	}));
22	22
23	23	session.on('stream', common.mustCall((stream) => {
24	24	stream.on('error', common.mustCall((err) => {
	25	+ assert.ok(errRegEx.test(err), `server stream err: ${err}`);
25	26	assert.strictEqual(session.closed, false);
26	27	assert.strictEqual(session.destroyed, true);
27		- assert(errRegEx.test(err));
28	28	assert.strictEqual(stream.rstCode, destroyCode);
29	29	}));
30	30
@@ -36,15 +36,15 @@ server.listen(0, common.mustCall(() => {
36	36	const session = http2.connect(`http://localhost:${server.address().port}`);
37	37
38	38	session.on('error', common.mustCall((err) => {
39		- assert(errRegEx.test(err));
	39	+ assert.ok(errRegEx.test(err), `client session err: ${err}`);
40	40	assert.strictEqual(session.closed, false);
41	41	assert.strictEqual(session.destroyed, true);
42	42	}));
43	43
44	44	const stream = session.request({ [http2.constants.HTTP2_HEADER_PATH]: '/' });
45	45
46	46	stream.on('error', common.mustCall((err) => {
47		- assert(errRegEx.test(err));
	47	+ assert.ok(errRegEx.test(err), `client stream err: ${err}`);
48	48	assert.strictEqual(stream.rstCode, destroyCode);
49	49	}));
50	50

0 commit comments

Comments

0 (0)