Commit 1d4fd21
src: guard against calling Init() multiple times
This function should only be called once. Calling it multiple times
would currently break Node.js (e.g. re-registering builtin modules
would break the linked list for them).
PR-URL: #26458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent dcfdef5 commit 1d4fd21
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -608,9 +608,14 @@ int ProcessGlobalArgs(std::vector<std::string>* args, | |||
| 608 | 608 | return 0; | |
| 609 | 609 | } | |
| 610 | 610 | ||
| 611 | + static std::atomic_bool init_called{false}; | ||
| 612 | + | ||
| 611 | 613 | int Init(std::vector<std::string>* argv, | |
| 612 | 614 | std::vector<std::string>* exec_argv, | |
| 613 | 615 | std::vector<std::string>* errors) { | |
| 616 | + // Make sure Init() is called only once. | ||
| 617 | + CHECK(!init_called.exchange(true)); | ||
| 618 | + | ||
| 614 | 619 | // Register built-in modules | |
| 615 | 620 | binding::RegisterBuiltinModules(); | |
| 616 | 621 | ||
0 commit comments