FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace `forEach()` with `for...of` in parallel tests · nodejs/node@1d5e5e8 · GitHub

/ node Public

Commit 1d5e5e8

Browse files
pmarkert
authored and
aduh95
committed
test: replace forEach() with for...of in parallel tests
Replace `Array.prototype.forEach()` with `for...of` loops across 17 tests in `test/parallel`, so each loop body reads as a plain statement rather than an arrow callback. None of the iterated values are sparse arrays, the one case where `forEach` and `for...of` genuinely differ, so both constructs visit the same elements in the same order. No callback relied on `this`, an early return, or async behaviour, and the number of assertions run in each file is unchanged. Signed-off-by: Phillip Markert <phillip@ephisys.com> PR-URL: #65272 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
1 parent 9346570 commit 1d5e5e8

17 files changed

Lines changed: 58 additions & 40 deletions

‎test/parallel/test-btoa-atob.js‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,17 @@ assert.strictEqual(atob({ toString: () => '' }), '');
2626
assert.strictEqual(atob({ [Symbol.toPrimitive]: () => '' }), '');
2727

2828
assert.throws(() => atob(Symbol()), /TypeError/);
29-
[
29+
const testCases = [
3030
undefined, false, () => {}, {}, [1],
3131
0, 1, 0n, 1n, -Infinity,
3232
'a', 'a\n\n\n', '\ra\r\r', ' a ', '\t\t\ta', 'a\f\f\f', '\ta\r \n\f',
33-
].forEach((value) =>
34-
// See #2 - https://html.spec.whatwg.org/multipage/webappapis.html#dom-atob
33+
];
34+
35+
// See #2 - https://html.spec.whatwg.org/multipage/webappapis.html#dom-atob
36+
for (const value of testCases) {
3537
assert.throws(() => atob(value), {
3638
constructor: DOMException,
3739
name: 'InvalidCharacterError',
3840
code: 5,
39-
}));
41+
});
42+
}

‎test/parallel/test-child-process-fork-stdio-string-variant.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,7 @@ function test(stringVariant) {
2929
child.on('exit', common.mustCall((code) => assert.strictEqual(code, 0)));
3030
}
3131

32-
['pipe', 'inherit', 'ignore'].forEach(test);
32+
const testCases = ['pipe', 'inherit', 'ignore'];
33+
for (const value of testCases) {
34+
test(value);
35+
}

‎test/parallel/test-child-process-ipc-next-tick.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ if (process.argv[2] === 'child') {
3232

3333
child.on('message', common.mustCall((msg) => {
3434
assert.strictEqual(msg, 'ready');
35-
values.forEach((value) => {
35+
for (const value of values) {
3636
child.send(value);
37-
});
37+
};
3838
}));
3939
}

‎test/parallel/test-debugger-pid.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ interfacer.stderr.setEncoding('utf-8');
1818
const onData = (data) => {
1919
data = (buffer + data).split('\n');
2020
buffer = data.pop();
21-
data.forEach((line) => interfacer.emit('line', line));
21+
for (const line of data) {
22+
interfacer.emit('line', line);
23+
}
2224
};
2325
interfacer.stdout.on('data', onData);
2426
interfacer.stderr.on('data', onData);

‎test/parallel/test-env-newprotomethod-remove-unnecessary-prototypes.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@ require('../common');
77

88
const assert = require('assert');
99
const { internalBinding } = require('internal/test/binding');
10-
[
10+
const testCases = [
1111
internalBinding('udp_wrap').UDP.prototype.bind6,
1212
internalBinding('tcp_wrap').TCP.prototype.bind6,
1313
internalBinding('udp_wrap').UDP.prototype.send6,
1414
internalBinding('tcp_wrap').TCP.prototype.bind,
1515
internalBinding('udp_wrap').UDP.prototype.close,
1616
internalBinding('tcp_wrap').TCP.prototype.open,
17-
].forEach((binding, i) => {
17+
];
18+
for (const [i, binding] of testCases.entries()) {
1819
assert.strictEqual('prototype' in binding, false, `Test ${i} failed`);
19-
});
20+
}

‎test/parallel/test-events-uncaught-exception-stack.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ const EventEmitter = require('events');
88
process.on('uncaughtException', common.mustCall((err) => {
99
const [firstLine, ...lines] = err.stack.split('\n');
1010
assert.strictEqual(firstLine, 'Error');
11-
lines.forEach((line) => {
11+
for (const line of lines) {
1212
assert.match(line, /^ {4}at/);
13-
});
13+
}
1414
}));
1515

1616
new EventEmitter().emit('error', new Error());

‎test/parallel/test-fs-buffertype-writesync.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ require('../common');
66
const assert = require('assert');
77
const fs = require('fs');
88

9-
[
9+
const testCases = [
1010
true, false, 0, 1, Infinity, () => {}, {}, [], undefined, null,
11-
].forEach((value) => {
11+
];
12+
for (const value of testCases) {
1213
assert.throws(
1314
() => fs.writeSync(1, value),
1415
{ message: /"buffer"/, code: 'ERR_INVALID_ARG_TYPE' }
1516
);
16-
});
17+
}

‎test/parallel/test-fs-cp-sync-verbatim-symlinks-invalid.mjs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import fixtures from '../common/fixtures.js';
88
tmpdir.refresh();
99

1010
const src = fixtures.path('copy/kitchen-sink');
11-
[1, [], {}, null, 1n, undefined, null, Symbol(), '', () => {}]
12-
.forEach((verbatimSymlinks) => {
13-
assert.throws(
14-
() => cpSync(src, src, { verbatimSymlinks }),
15-
{ code: 'ERR_INVALID_ARG_TYPE' }
16-
);
17-
});
11+
const testCases = [1, [], {}, null, 1n, undefined, null, Symbol(), '', () => {}];
12+
for (const verbatimSymlinks of testCases) {
13+
assert.throws(
14+
() => cpSync(src, src, { verbatimSymlinks }),
15+
{ code: 'ERR_INVALID_ARG_TYPE' }
16+
);
17+
}

‎test/parallel/test-fs-readlink-type-check.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ const common = require('../common');
44
const assert = require('assert');
55
const fs = require('fs');
66

7-
[false, 1, {}, [], null, undefined].forEach((i) => {
7+
const testCases = [false, 1, {}, [], null, undefined];
8+
for (const i of testCases) {
89
assert.throws(
910
() => fs.readlink(i, common.mustNotCall()),
1011
{
@@ -19,4 +20,4 @@ const fs = require('fs');
1920
name: 'TypeError'
2021
}
2122
);
22-
});
23+
}

‎test/parallel/test-fs-rmdir-type-check.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ const common = require('../common');
44
const assert = require('assert');
55
const fs = require('fs');
66

7-
[false, 1, [], {}, null, undefined].forEach((i) => {
7+
const testCases = [false, 1, [], {}, null, undefined];
8+
for (const i of testCases) {
89
assert.throws(
910
() => fs.rmdir(i, common.mustNotCall()),
1011
{
@@ -19,4 +20,4 @@ const fs = require('fs');
1920
name: 'TypeError'
2021
}
2122
);
22-
});
23+
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL