Commit 1de25f2
tools: do not build addons during compilation
The current makefile runs both `cctest` and `build-addons` in parallel
under the assumption that both rely on `all`. Unfortunately
`build-addons` does not rely on all, and there is an edge case where
by it is possible to call `build-addons` while compilation is still
happening.
This patch takes the simplest route by forcing `build-addons` and
`cctest` to run in sequence like the other test targets. This ensures
that `build-addons` will never be run during compilation.
It would be possible to modify `build-addons` to rely on `all` but it
would be a much more aggressive change to the MAKEFILE for a fairly
minor perf bump, as cctest is so fast.
PR-URL: #6723
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 1370fdc commit 1de25f2
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -114,7 +114,9 @@ v8: | |||
| 114 | 114 | tools/make-v8.sh v8 | |
| 115 | 115 | $(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS) | |
| 116 | 116 | ||
| 117 | - test: | build-addons cctest # Both targets depend on 'all'. | ||
| 117 | + test: all | ||
| 118 | + $(MAKE) build-addons | ||
| 119 | + $(MAKE) cctest | ||
| 118 | 120 | $(PYTHON) tools/test.py --mode=release -J \ | |
| 119 | 121 | addon doctool message parallel sequential | |
| 120 | 122 | $(MAKE) lint | |
0 commit comments