Commit 1e3aed0
test: fix flaky parallel/test-http2-client-upload
In parallel/test-http2-client-upload, the `client.destroy()`
call could terminate the connection before all data was sent
over the wire successfully.
Using `client.shutdown()` removes the flakiness.
Also, listen on `req.on('finish')` rather than the file stream’s
`end` event, since we’re not interested in when the source stream
finishes, but rather when the HTTP/2 stream finishes.
PR-URL: #17361
Refs: #17356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>1 parent 7ae7124 commit 1e3aed0
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ fs.readFile(loc, common.mustCall((err, data) => { | |||
| 38 | 38 | function maybeClose() { | |
| 39 | 39 | if (--remaining === 0) { | |
| 40 | 40 | server.close(); | |
| 41 | - client.destroy(); | ||
| 41 | + client.shutdown(); | ||
| 42 | 42 | } | |
| 43 | 43 | } | |
| 44 | 44 | ||
@@ -47,7 +47,7 @@ fs.readFile(loc, common.mustCall((err, data) => { | |||
| 47 | 47 | req.resume(); | |
| 48 | 48 | req.on('end', common.mustCall(maybeClose)); | |
| 49 | 49 | const str = fs.createReadStream(loc); | |
| 50 | - str.on('end', common.mustCall(maybeClose)); | ||
| 50 | + req.on('finish', common.mustCall(maybeClose)); | ||
| 51 | 51 | str.pipe(req); | |
| 52 | 52 | })); | |
| 53 | 53 | })); | |
0 commit comments