Commit 1ef2811
test: only assert on first lines of TLS trace
The TLS trace data is best-effort, and enough can be dropped from pipe
buffers that only the start of the trace is detected. Only assert on the
first line of the trace, it should not get dropped, and it's enough to
check that trace was enabled via CLI.
PR-URL: #28043
Fixes: #27636
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 9dd4813 commit 1ef2811
2 files changed
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,8 +9,6 @@ prefix parallel | |||
| 9 | 9 | test-net-connect-options-port: PASS,FLAKY | |
| 10 | 10 | # https://github.com/nodejs/node/issues/26401 | |
| 11 | 11 | test-worker-prof: PASS,FLAKY | |
| 12 | - # https://github.com/nodejs/node/issues/27553 | ||
| 13 | - test-tls-enable-trace-cli: PASS,FLAKY | ||
| 14 | 12 | ||
| 15 | 13 | [$system==win32] | |
| 16 | 14 | test-http2-pipe: PASS,FLAKY | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,6 @@ child.on('close', common.mustCall((code, signal) => { | |||
| 37 | 37 | assert.strictEqual(stdout.trim(), ''); | |
| 38 | 38 | assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr)); | |
| 39 | 39 | assert(/Sent Record/.test(stderr)); | |
| 40 | - assert(/Received Record/.test(stderr)); | ||
| 41 | 40 | })); | |
| 42 | 41 | ||
| 43 | 42 | function test() { | |
0 commit comments