lib: refactor source_map to avoid unsafe array iteration · nodejs/node@1ef92f6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1ef92f6

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

ruyadorno

committed

lib: refactor source_map to avoid unsafe array iteration

PR-URL: #36734 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>

1 parent 0d71947 commit 1ef92f6
Copy full SHA for 1ef92f6

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/source_map
  • source_map.js
  • source_map_cache.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/source_map/source_map.js‎

Copy file name to clipboardExpand all lines: lib/internal/source_map/source_map.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -334,8 +334,8 @@ function cloneSourceMapV3(payload) {
334	334	* @return {number}
335	335	*/
336	336	function compareSourceMapEntry(entry1, entry2) {
337		- const [lineNumber1, columnNumber1] = entry1;
338		- const [lineNumber2, columnNumber2] = entry2;
	337	+ const { 0: lineNumber1, 1: columnNumber1 } = entry1;
	338	+ const { 0: lineNumber2, 1: columnNumber2 } = entry2;
339	339	if (lineNumber1 !== lineNumber2) {
340	340	return lineNumber1 - lineNumber2;
341	341	}

Collapse file

‎lib/internal/source_map/source_map_cache.js‎

Copy file name to clipboardExpand all lines: lib/internal/source_map/source_map_cache.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -138,7 +138,7 @@ function sourceMapFromFile(mapURL) {
138	138	// data:[<mediatype>][;base64],<data> see:
139	139	// https://tools.ietf.org/html/rfc2397#section-2
140	140	function sourceMapFromDataUrl(sourceURL, url) {
141		- const [format, data] = StringPrototypeSplit(url, ',');
	141	+ const { 0: format, 1: data } = StringPrototypeSplit(url, ',');
142	142	const splitFormat = StringPrototypeSplit(format, ';');
143	143	const contentType = splitFormat[0];
144	144	const base64 = splitFormat[splitFormat.length - 1] === 'base64';

0 commit comments

Comments

0 (0)