Commit 1f16df2
deps: V8: cherry-pick b33bf2dfd261
Original commit message:
Ignore --predictable when computing flag list hashes
This allows reproducible code cache generation.
Refs: #48749
Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#88943}
Refs: v8/v8@b33bf2d
PR-URL: #49703
Refs: v8/v8@de9a5de
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent eded29c commit 1f16df2
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -539,8 +539,10 @@ uint32_t ComputeFlagListHash() { | |||
| 539 | 539 | // We want to be able to flip --profile-deserialization without | |
| 540 | 540 | // causing the code cache to get invalidated by this hash. | |
| 541 | 541 | if (flag.PointsTo(&v8_flags.profile_deserialization)) continue; | |
| 542 | - // Skip v8_flags.random_seed to allow predictable code caching. | ||
| 542 | + // Skip v8_flags.random_seed and v8_flags.predictable to allow predictable | ||
| 543 | + // code caching. | ||
| 543 | 544 | if (flag.PointsTo(&v8_flags.random_seed)) continue; | |
| 545 | + if (flag.PointsTo(&v8_flags.predictable)) continue; | ||
| 544 | 546 | modified_args_as_string << flag; | |
| 545 | 547 | } | |
| 546 | 548 | std::string args(modified_args_as_string.str()); | |
0 commit comments