Commit 1f4f811
http2: log debug only when in debug mode
PR-URL: #43626
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>1 parent 0783663 commit 1f4f811
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -190,10 +190,10 @@ let debug = require('internal/util/debuglog').debuglog('http2', (fn) => { | |||
| 190 | 190 | debug = fn; | |
| 191 | 191 | }); | |
| 192 | 192 | ||
| 193 | - // TODO(addaleax): See if this can be made more efficient by figuring out | ||
| 194 | - // whether debugging is enabled before we perform any further steps. Currently, | ||
| 195 | - // this seems pretty fast, though. | ||
| 196 | 193 | function debugStream(id, sessionType, message, ...args) { | |
| 194 | + if (!debug.enabled) { | ||
| 195 | + return; | ||
| 196 | + } | ||
| 197 | 197 | debug('Http2Stream %s [Http2Session %s]: ' + message, | |
| 198 | 198 | id, sessionName(sessionType), ...new SafeArrayIterator(args)); | |
| 199 | 199 | } | |
0 commit comments