Commit 1fd1340
test: pass data into napi_create_external
Since v8 10.1 v8::External::New DCHECKs that the data passed
into it cannot be a nullptr because that's not serializable
as external references. This updates the test to pass a
dummy data pointer to the call - which does not matter for the
test since we only care about whether the finalizer is
called.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234
PR-URL: #42532
Refs: #42115
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 7bf8117 commit 1fd1340
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,6 +2,7 @@ | |||
| 2 | 2 | #include "../common.h" | |
| 3 | 3 | ||
| 4 | 4 | static bool exceptionWasPending = false; | |
| 5 | + static int num = 0x23432; | ||
| 5 | 6 | ||
| 6 | 7 | static napi_value returnException(napi_env env, napi_callback_info info) { | |
| 7 | 8 | size_t argc = 1; | |
@@ -83,7 +84,7 @@ static napi_value createExternal(napi_env env, napi_callback_info info) { | |||
| 83 | 84 | napi_value external; | |
| 84 | 85 | ||
| 85 | 86 | NODE_API_CALL(env, | |
| 86 | - napi_create_external(env, NULL, finalizer, NULL, &external)); | ||
| 87 | + napi_create_external(env, &num, finalizer, NULL, &external)); | ||
| 87 | 88 | ||
| 88 | 89 | return external; | |
| 89 | 90 | } | |
0 commit comments