Commit 2069c4e
build: disable libstdc++ debug containers globally
Different parts of the debug build were using differently sized
std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and
sometimes not. That ended about as well as you would expect.
Remove the flag.
Fixes: #30056
PR-URL: #30147
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 435341a commit 2069c4e
2 files changed
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,10 +30,6 @@ | |||
| 30 | 30 | 'openssl_fips%': '', | |
| 31 | 31 | 'openssl_no_asm%': 0, | |
| 32 | 32 | ||
| 33 | - # Some STL containers (e.g. std::vector) do not preserve ABI compatibility | ||
| 34 | - # between debug and non-debug mode. | ||
| 35 | - 'disable_glibcxx_debug': 1, | ||
| 36 | - | ||
| 37 | 33 | # Don't use ICU data file (icudtl.dat) from V8, we use our own. | |
| 38 | 34 | 'icu_use_data_file_flag%': 0, | |
| 39 | 35 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -64,9 +64,6 @@ | |||
| 64 | 64 | # Print to stdout on Android. | |
| 65 | 65 | 'v8_android_log_stdout%': 0, | |
| 66 | 66 | ||
| 67 | - # Force disable libstdc++ debug mode. | ||
| 68 | - 'disable_glibcxx_debug%': 0, | ||
| 69 | - | ||
| 70 | 67 | 'v8_enable_backtrace%': 0, | |
| 71 | 68 | ||
| 72 | 69 | # Enable profiling support. Only required on Windows. | |
@@ -1167,11 +1164,6 @@ | |||
| 1167 | 1164 | # Support for backtrace_symbols. | |
| 1168 | 1165 | 'ldflags': [ '-rdynamic' ], | |
| 1169 | 1166 | }], | |
| 1170 | - ['OS=="linux" and disable_glibcxx_debug==0', { | ||
| 1171 | - # Enable libstdc++ debugging facilities to help catch problems | ||
| 1172 | - # early, see http://crbug.com/65151 . | ||
| 1173 | - 'defines': ['_GLIBCXX_DEBUG=1',], | ||
| 1174 | - }], | ||
| 1175 | 1167 | ['OS=="aix"', { | |
| 1176 | 1168 | 'ldflags': [ '-Wl,-bbigtoc' ], | |
| 1177 | 1169 | 'conditions': [ | |
0 commit comments