test: resolve race condition in test-net-write-fully-async-* · nodejs/node@20c032e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 20c032e

Browse filesBrowse the repository at this point in the historyBrowse files

mcollina

authored and

aduh95

committed

test: resolve race condition in test-net-write-fully-async-*

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #57022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parent 3d103ec commit 20c032e
Copy full SHA for 20c032e

2 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-net-write-fully-async-buffer.js
  • test-net-write-fully-async-hex-string.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-net-write-fully-async-buffer.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-write-fully-async-buffer.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -11,14 +11,14 @@ const data = Buffer.alloc(1000000);
11	11
12	12	const server = net.createServer(common.mustCall(function(conn) {
13	13	conn.resume();
	14	+ server.close();
14	15	})).listen(0, common.mustCall(function() {
15	16	const conn = net.createConnection(this.address().port, common.mustCall(() => {
16	17	let count = 0;
17	18
18	19	function writeLoop() {
19		- if (count++ === 200) {
20		- conn.destroy();
21		- server.close();
	20	+ if (count++ === 20) {
	21	+ conn.end();
22	22	return;
23	23	}
24	24

Collapse file

‎test/parallel/test-net-write-fully-async-hex-string.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-write-fully-async-hex-string.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -9,14 +9,14 @@ const data = Buffer.alloc(1000000).toString('hex');
9	9
10	10	const server = net.createServer(common.mustCall(function(conn) {
11	11	conn.resume();
	12	+ server.close();
12	13	})).listen(0, common.mustCall(function() {
13	14	const conn = net.createConnection(this.address().port, common.mustCall(() => {
14	15	let count = 0;
15	16
16	17	function writeLoop() {
17	18	if (count++ === 20) {
18		- conn.destroy();
19		- server.close();
	19	+ conn.end();
20	20	return;
21	21	}
22	22

0 commit comments

Comments

0 (0)