test: fix misplaced ) in http response statuscode test · nodejs/node@21704a3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 21704a3

Browse filesBrowse the repository at this point in the historyBrowse files

nfriedly

authored and

MylesBorins

committed

test: fix misplaced ) in http response statuscode test

This fixes a misplaced parenthesis in each of the tests in test/parallel/test-http-response-statuscodes.js, causing the tests to pass as long as any error was thrown, without validating the error message. PR-URL: #10692 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 8565a06 commit 21704a3
Copy full SHA for 21704a3

1 file changed

+12-12Lines changed: 12 additions & 12 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-response-statuscode.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-response-statuscode.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-response-statuscode.js

+12-12Lines changed: 12 additions & 12 deletions

Original file line number	Diff line number	Diff line change
@@ -11,62 +11,62 @@ const server = http.Server(common.mustCall(function(req, res) {
11	11	case 0:
12	12	assert.throws(common.mustCall(() => {
13	13	res.writeHead(-1);
14		- }, /invalid status code/i));
	14	+ }), /invalid status code/i);
15	15	break;
16	16	case 1:
17	17	assert.throws(common.mustCall(() => {
18	18	res.writeHead(Infinity);
19		- }, /invalid status code/i));
	19	+ }), /invalid status code/i);
20	20	break;
21	21	case 2:
22	22	assert.throws(common.mustCall(() => {
23	23	res.writeHead(NaN);
24		- }, /invalid status code/i));
	24	+ }), /invalid status code/i);
25	25	break;
26	26	case 3:
27	27	assert.throws(common.mustCall(() => {
28	28	res.writeHead({});
29		- }, /invalid status code/i));
	29	+ }), /invalid status code/i);
30	30	break;
31	31	case 4:
32	32	assert.throws(common.mustCall(() => {
33	33	res.writeHead(99);
34		- }, /invalid status code/i));
	34	+ }), /invalid status code/i);
35	35	break;
36	36	case 5:
37	37	assert.throws(common.mustCall(() => {
38	38	res.writeHead(1000);
39		- }, /invalid status code/i));
	39	+ }), /invalid status code/i);
40	40	break;
41	41	case 6:
42	42	assert.throws(common.mustCall(() => {
43	43	res.writeHead('1000');
44		- }, /invalid status code/i));
	44	+ }), /invalid status code/i);
45	45	break;
46	46	case 7:
47	47	assert.throws(common.mustCall(() => {
48	48	res.writeHead(null);
49		- }, /invalid status code/i));
	49	+ }), /invalid status code/i);
50	50	break;
51	51	case 8:
52	52	assert.throws(common.mustCall(() => {
53	53	res.writeHead(true);
54		- }, /invalid status code/i));
	54	+ }), /invalid status code/i);
55	55	break;
56	56	case 9:
57	57	assert.throws(common.mustCall(() => {
58	58	res.writeHead([]);
59		- }, /invalid status code/i));
	59	+ }), /invalid status code/i);
60	60	break;
61	61	case 10:
62	62	assert.throws(common.mustCall(() => {
63	63	res.writeHead('this is not valid');
64		- }, /invalid status code/i));
	64	+ }), /invalid status code/i);
65	65	break;
66	66	case 11:
67	67	assert.throws(common.mustCall(() => {
68	68	res.writeHead('404 this is not valid either');
69		- }, /invalid status code/i));
	69	+ }), /invalid status code/i);
70	70	this.close();
71	71	break;
72	72	default:

0 commit comments

Comments

0 (0)