lib: use null-prototype objects for property descriptors · nodejs/node@2233567 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2233567

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

targos

committed

lib: use null-prototype objects for property descriptors

PR-URL: #43473 Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent b9198d9 commit 2233567
Copy full SHA for 2233567

3 files changed

+7-3Lines changed: 7 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • buffer.js
  • internal/webstreams
    • readablestream.js
    • util.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/buffer.js‎

Copy file name to clipboardExpand all lines: lib/buffer.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -132,11 +132,13 @@ addBufferPrototypeMethods(Buffer.prototype);
132	132
133	133	const constants = ObjectDefineProperties({}, {
134	134	MAX_LENGTH: {
	135	+ __proto__: null,
135	136	value: kMaxLength,
136	137	writable: false,
137	138	enumerable: true
138	139	},
139	140	MAX_STRING_LENGTH: {
	141	+ __proto__: null,
140	142	value: kStringMaxLength,
141	143	writable: false,
142	144	enumerable: true

Collapse file

‎lib/internal/webstreams/readablestream.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/readablestream.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1181,9 +1181,9 @@ function createTeeReadableStream(start, pull, cancel) {
1181	1181	setupReadableStreamDefaultControllerFromSource(
1182	1182	this,
1183	1183	ObjectCreate(null, {
1184		- start: { value: start },
1185		- pull: { value: pull },
1186		- cancel: { value: cancel }
	1184	+ start: { __proto__: null, value: start },
	1185	+ pull: { __proto__: null, value: pull },
	1186	+ cancel: { __proto__: null, value: cancel }
1187	1187	}),
1188	1188	1,
1189	1189	() => 1);

Collapse file

‎lib/internal/webstreams/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/util.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -49,11 +49,13 @@ const kType = Symbol('kType');
49	49
50	50	const AsyncIterator = ObjectCreate(AsyncIteratorPrototype, {
51	51	next: {
	52	+ __proto__: null,
52	53	configurable: true,
53	54	enumerable: true,
54	55	writable: true,
55	56	},
56	57	return: {
	58	+ __proto__: null,
57	59	configurable: true,
58	60	enumerable: true,
59	61	writable: true,

0 commit comments

Comments

0 (0)