Commit 2249234
committed
fs: invoke callbacks with undefined context
Many callbacks appear to be invoked with `this` set to `undefined`
including `fs.stat()`, `fs.lstat()`, and `fs.fstat()`.
However, some such as `fs.open()` and `fs.mkdtemp()` invoke their
callbacks with `this` set to `null`. Change to `undefined`.
PR-URL: #14645
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent c6126b1 commit 2249234
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -132,7 +132,7 @@ function makeCallback(cb) { | |||
| 132 | 132 | } | |
| 133 | 133 | ||
| 134 | 134 | return function() { | |
| 135 | - return cb.apply(null, arguments); | ||
| 135 | + return cb.apply(undefined, arguments); | ||
| 136 | 136 | }; | |
| 137 | 137 | } | |
| 138 | 138 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,7 +20,7 @@ assert(common.fileExists(utf8)); | |||
| 20 | 20 | function handler(err, folder) { | |
| 21 | 21 | assert.ifError(err); | |
| 22 | 22 | assert(common.fileExists(folder)); | |
| 23 | - assert.strictEqual(this, null); | ||
| 23 | + assert.strictEqual(this, undefined); | ||
| 24 | 24 | } | |
| 25 | 25 | ||
| 26 | 26 | fs.mkdtemp(path.join(common.tmpDir, 'bar.'), common.mustCall(handler)); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -66,7 +66,7 @@ fs.open('.', 'r', undefined, common.mustCall(function(err, fd) { | |||
| 66 | 66 | // Confirm that we are not running in the context of the internal binding | |
| 67 | 67 | // layer. | |
| 68 | 68 | // Ref: https://github.com/nodejs/node/commit/463d6bac8b349acc462d345a6e298a76f7d06fb1 | |
| 69 | - assert.strictEqual(this, null); | ||
| 69 | + assert.strictEqual(this, undefined); | ||
| 70 | 70 | })); | |
| 71 | 71 | ||
| 72 | 72 | // fstatSync | |
0 commit comments