cli: support --experimental-top-level-await in NODE_OPTIONS · nodejs/node@22b5ec1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 591
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 22b5ec1

Browse filesBrowse the repository at this point in the historyBrowse files

dfabulich

authored and

codebytere

committed

cli: support --experimental-top-level-await in NODE_OPTIONS

PR-URL: #33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent 011fe1d commit 22b5ec1
Copy full SHA for 22b5ec1

3 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • cli.md
• src
  • node_options.cc
• test/parallel
  • test-cli-node-options.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1185,6 +1185,7 @@ Node.js options that are allowed are:
1185	1185	* `--experimental-policy`
1186	1186	* `--experimental-repl-await`
1187	1187	* `--experimental-specifier-resolution`
	1188	+ * `--experimental-top-level-await`
1188	1189	* `--experimental-vm-modules`
1189	1190	* `--experimental-wasi-unstable-preview1`
1190	1191	* `--experimental-wasm-modules`

Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -599,7 +599,8 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
599	599
600	600	AddOption("--experimental-top-level-await",
601	601	"enable experimental support for ECMAScript Top-Level Await",
602		- &PerIsolateOptions::experimental_top_level_await);
	602	+ &PerIsolateOptions::experimental_top_level_await,
	603	+ kAllowedInEnvironment);
603	604	AddOption("--harmony-top-level-await", "", V8Option{});
604	605	Implies("--experimental-top-level-await", "--harmony-top-level-await");
605	606	Implies("--harmony-top-level-await", "--experimental-top-level-await");

Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -78,6 +78,10 @@ expect('--stack-trace-limit=100',
78	78	if (!['arm', 'arm64', 's390x'].includes(process.arch))
79	79	expect('--interpreted-frames-native-stack', 'B\n');
80	80
	81	+ // Workers can't eval as ES Modules. https://github.com/nodejs/node/issues/30682
	82	+ expectNoWorker('--experimental-top-level-await --input-type=module',
	83	+ 'B\n', 'console.log(await "B")');
	84	+
81	85	function expectNoWorker(opt, want, command, wantsError) {
82	86	expect(opt, want, command, wantsError, false);
83	87	}

0 commit comments

Comments

0 (0)