Commit 22ea3a8
test: remove common.PORT from test-tlswrap
`test/async-hooks/test/test-tlswrap.js` uses `common.PORT` but
async-hooks tests are run in parallel. Another test using port 0 could
result in a port collision. Remove `common.PORT` from the test.
PR-URL: #15742
Ref: #14404 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3f12109 commit 22ea3a8
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,15 +25,15 @@ const server = tls | |||
| 25 | 25 | }) | |
| 26 | 26 | .on('listening', common.mustCall(onlistening)) | |
| 27 | 27 | .on('secureConnection', common.mustCall(onsecureConnection)) | |
| 28 | - .listen(common.PORT); | ||
| 28 | + .listen(0); | ||
| 29 | 29 | ||
| 30 | 30 | let svr, client; | |
| 31 | 31 | function onlistening() { | |
| 32 | 32 | // | |
| 33 | 33 | // Creating client and connecting it to server | |
| 34 | 34 | // | |
| 35 | 35 | tls | |
| 36 | - .connect(common.PORT, { rejectUnauthorized: false }) | ||
| 36 | + .connect(server.address().port, { rejectUnauthorized: false }) | ||
| 37 | 37 | .on('secureConnect', common.mustCall(onsecureConnect)); | |
| 38 | 38 | ||
| 39 | 39 | const as = hooks.activitiesOfTypes('TLSWRAP'); | |
0 commit comments