Commit 2308a27
src: only set v8 flags if argc > 1
ParseArgs sets the first element of v8_args to argv[0], so v8_argc will
always be at least 1. This change only calls
V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional
startup improvement of ~5%.
PR-URL: #2646
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>1 parent 205aab3 commit 2308a27
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3688,7 +3688,7 @@ void Init(int* argc, | |||
| 3688 | 3688 | #endif | |
| 3689 | 3689 | // The const_cast doesn't violate conceptual const-ness. V8 doesn't modify | |
| 3690 | 3690 | // the argv array or the elements it points to. | |
| 3691 | - if (v8_argc != 0) | ||
| 3691 | + if (v8_argc > 1) | ||
| 3692 | 3692 | V8::SetFlagsFromCommandLine(&v8_argc, const_cast<char**>(v8_argv), true); | |
| 3693 | 3693 | ||
| 3694 | 3694 | // Anything that's still in v8_argv is not a V8 or a node option. | |
0 commit comments