Commit 23d41fb
test: fix test-net-connect-econnrefused (again)
test-net-connect-econnrefused was recently fixed, but only in certain
circumstances. This change allows it to succeed whether it is invoked
with `node` or `tools/test.py`. Makes sure no Socket handles are left,
which is what the test is trying to determine, rather than failing if
there are no handles of any kind left.
PR-URL: #25438
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 5fe7741 commit 23d41fb
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -50,7 +50,8 @@ function pummel() { | |||
| 50 | 50 | function check() { | |
| 51 | 51 | setTimeout(function() { | |
| 52 | 52 | assert.strictEqual(process._getActiveRequests().length, 0); | |
| 53 | - assert.strictEqual(process._getActiveHandles().length, 1); // the timer | ||
| 53 | + const activeHandles = process._getActiveHandles(); | ||
| 54 | + assert.ok(activeHandles.every((val) => val.constructor.name !== 'Socket')); | ||
| 54 | 55 | check_called = true; | |
| 55 | 56 | }, 0); | |
| 56 | 57 | } | |
0 commit comments