Commit 23f66b1
test: move test-shadow-realm-gc.js to known_issues
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.
PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 8e6ee53 commit 23f66b1
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,6 +11,9 @@ prefix known_issues | |||
| 11 | 11 | # foreseeable future. The test itself is flaky and skipped. It | |
| 12 | 12 | # serves as a demonstration of the issue only. | |
| 13 | 13 | test-vm-timeout-escape-queuemicrotask: SKIP | |
| 14 | + # Skipping it because it crashes out of OOM instead of exiting. | ||
| 15 | + # https://github.com/nodejs/node/issues/47353 | ||
| 16 | + test-shadow-realm-gc: SKIP | ||
| 14 | 17 | ||
| 15 | 18 | [$system==win32] | |
| 16 | 19 | ||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,5 +8,6 @@ | |||
| 8 | 8 | require('../common'); | |
| 9 | 9 | ||
| 10 | 10 | for (let i = 0; i < 1000; i++) { | |
| 11 | - new ShadowRealm(); | ||
| 11 | + const realm = new ShadowRealm(); | ||
| 12 | + realm.evaluate('new TextEncoder(); 1;'); | ||
| 12 | 13 | } | |
0 commit comments