Commit 2488bc0
doc: clean up weird notes about reentrancy
All N-API methods are reentrant, it does not make sense to talk
about specific ones here.
Some of these methods can run JS code, which of course can run
other N-API code. For those methods, let’s note that down explicitly.
PR-URL: #40107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 8b80dcb commit 2488bc0
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3303,7 +3303,6 @@ Returns `napi_ok` if the API succeeded. | |||
| 3303 | 3303 | ||
| 3304 | 3304 | This API implements the abstract operation `ToBoolean()` as defined in | |
| 3305 | 3305 | [Section 7.1.2][] of the ECMAScript Language Specification. | |
| 3306 | - This API can be re-entrant if getters are defined on the passed-in `Object`. | ||
| 3307 | 3306 | ||
| 3308 | 3307 | ### napi_coerce_to_number | |
| 3309 | 3308 | <!-- YAML | |
@@ -3325,7 +3324,8 @@ Returns `napi_ok` if the API succeeded. | |||
| 3325 | 3324 | ||
| 3326 | 3325 | This API implements the abstract operation `ToNumber()` as defined in | |
| 3327 | 3326 | [Section 7.1.3][] of the ECMAScript Language Specification. | |
| 3328 | - This API can be re-entrant if getters are defined on the passed-in `Object`. | ||
| 3327 | + This function potentially runs JS code if the passed-in value is an | ||
| 3328 | + object. | ||
| 3329 | 3329 | ||
| 3330 | 3330 | ### napi_coerce_to_object | |
| 3331 | 3331 | <!-- YAML | |
@@ -3347,7 +3347,6 @@ Returns `napi_ok` if the API succeeded. | |||
| 3347 | 3347 | ||
| 3348 | 3348 | This API implements the abstract operation `ToObject()` as defined in | |
| 3349 | 3349 | [Section 7.1.13][] of the ECMAScript Language Specification. | |
| 3350 | - This API can be re-entrant if getters are defined on the passed-in `Object`. | ||
| 3351 | 3350 | ||
| 3352 | 3351 | ### napi_coerce_to_string | |
| 3353 | 3352 | <!-- YAML | |
@@ -3369,7 +3368,8 @@ Returns `napi_ok` if the API succeeded. | |||
| 3369 | 3368 | ||
| 3370 | 3369 | This API implements the abstract operation `ToString()` as defined in | |
| 3371 | 3370 | [Section 7.1.13][] of the ECMAScript Language Specification. | |
| 3372 | - This API can be re-entrant if getters are defined on the passed-in `Object`. | ||
| 3371 | + This function potentially runs JS code if the passed-in value is an | ||
| 3372 | + object. | ||
| 3373 | 3373 | ||
| 3374 | 3374 | ### napi_typeof | |
| 3375 | 3375 | <!-- YAML | |
0 commit comments